OpenEngSB
  1. OpenEngSB
  2. OPENENGSB-1639

Create integration tests for the console commands

    Details

      Description

      To insure that the openengsb console commands are working as expected, integration test(s) should be added

        Gliffy Diagrams

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          Andreas Pieber added a comment -

          absolutely! I think this would really increase stability of the console application; I think a look into the integration tests @ the karaf project could really help here

          Show
          Andreas Pieber added a comment - absolutely! I think this would really increase stability of the console application; I think a look into the integration tests @ the karaf project could really help here
          Hide
          Andreas Pieber added a comment - - edited

          OK, this one is a so-called: "pain in the ass"... The problem is the following: http://felix.apache.org/site/provisional-osgi-api-policy.html Taking a look at the exports shows in addition:

          org.apache.felix.service.command;mandatory:=status;status=provisional;version=0.6.1,
          org.apache.felix.service.threadio;mandatory:=status;status=provisional;version=0.6.1,

          So, all in all the "mandatory:=status;status=provisional" is what makes the problem since the dyanmic import also seams to require such an attribute. I really have to check if we can add this without danger to pax-exam and see what happens. If I find the right place in pax-exam I'm not sure if we can get out a new release out too quickly (since we're still in RC phase). But I'm sure we'll can make something here...

          Show
          Andreas Pieber added a comment - - edited OK, this one is a so-called: "pain in the ass"... The problem is the following: http://felix.apache.org/site/provisional-osgi-api-policy.html Taking a look at the exports shows in addition: org.apache.felix.service.command;mandatory:=status;status=provisional;version=0.6.1, org.apache.felix.service.threadio;mandatory:=status;status=provisional;version=0.6.1, So, all in all the "mandatory:=status;status=provisional" is what makes the problem since the dyanmic import also seams to require such an attribute. I really have to check if we can add this without danger to pax-exam and see what happens. If I find the right place in pax-exam I'm not sure if we can get out a new release out too quickly (since we're still in RC phase). But I'm sure we'll can make something here...
          Hide
          Andreas Pieber added a comment -

          ok, finally I've found the workaround and pushed an initial (working) integration test to the https://github.com/openengsb/openengsb-framework/tree/OPENENGSB-1639/Console-IT branch. Now you can start adding integration tests/finishing this issue.

          Show
          Andreas Pieber added a comment - ok, finally I've found the workaround and pushed an initial (working) integration test to the https://github.com/openengsb/openengsb-framework/tree/OPENENGSB-1639/Console-IT branch. Now you can start adding integration tests/finishing this issue.
          Hide
          Philipp Hoenisch added a comment -

          Works like a charm, thank you

          Show
          Philipp Hoenisch added a comment - Works like a charm, thank you
          Hide
          Andreas Pieber added a comment -

          you're welcome! believe me... was a pain in the ass

          Show
          Andreas Pieber added a comment - you're welcome! believe me... was a pain in the ass
          Hide
          Philipp Hoenisch added a comment -

          i've created some integration tests in the current master, if the pull request is ok I will back port this to the 2.1.0 branch.

          Show
          Philipp Hoenisch added a comment - i've created some integration tests in the current master, if the pull request is ok I will back port this to the 2.1.0 branch.
          Hide
          Philipp Hoenisch added a comment -

          fixed in master and backported to v2.x.y and v2.0.x

          Show
          Philipp Hoenisch added a comment - fixed in master and backported to v2.x.y and v2.0.x

            People

            • Assignee:
              Philipp Hoenisch
              Reporter:
              Philipp Hoenisch
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: