OpenEngSB
  1. OpenEngSB
  2. OPENENGSB-2260

Remote interface cannot work correctly with openengsb model objects

    Details

      Description

      The remote interface does not handle the openengsb domain objects well...

        Gliffy Diagrams

        Error rendering 'com.meetme.plugins.jira.gerrit-plugin:gerritreviewsmodule'. Please contact your JIRA administrators.

          Activity

          Hide
          Felix Mayerhuber added a comment - - edited
          • convert Proxies into List of OpenEngSBModelEntries (getOpenEngSBModelEntries)
          • implement as a filter on both sides
          • filter: checks if Object is instanceof OpenEngSBModel -> convert
            if List of OpenEngSBModelEntry -> create Proxy and give list as parameter
          • move ModelFactory of the EKB into common as static Util class
          Show
          Felix Mayerhuber added a comment - - edited convert Proxies into List of OpenEngSBModelEntries (getOpenEngSBModelEntries) implement as a filter on both sides filter: checks if Object is instanceof OpenEngSBModel -> convert if List of OpenEngSBModelEntry -> create Proxy and give list as parameter move ModelFactory of the EKB into common as static Util class
          Hide
          Felix Mayerhuber added a comment -
          • introduce new wrapper class consisting of the class object of the interface and the OpenEngSBModelEntries
          • filters has to be set in the JMS Ports. At the Outgoing it should be the last, at the Incoming it must be hard coded in DefaultSecureMethodCallFilterFactory->createFilterList->Last but one element there.
          • filters should be like JsonMethodCallMarshalFilter but instead of <String,String>, it should be <MethodCallRequest, MethodResultMessage>
          • add a test to JMSPortIT to test if the conversion is done correctly
          Show
          Felix Mayerhuber added a comment - introduce new wrapper class consisting of the class object of the interface and the OpenEngSBModelEntries filters has to be set in the JMS Ports. At the Outgoing it should be the last, at the Incoming it must be hard coded in DefaultSecureMethodCallFilterFactory->createFilterList->Last but one element there. filters should be like JsonMethodCallMarshalFilter but instead of <String,String>, it should be <MethodCallRequest, MethodResultMessage> add a test to JMSPortIT to test if the conversion is done correctly
          Hide
          Felix Mayerhuber added a comment -

          could someone please tell me how a test for this should look like? In the JMSPortIT there are so far only security tests or am I wrong?

          Show
          Felix Mayerhuber added a comment - could someone please tell me how a test for this should look like? In the JMSPortIT there are so far only security tests or am I wrong?
          Hide
          Andreas Pieber added a comment -

          almost done as it seams; only the itest is missing

          Show
          Andreas Pieber added a comment - almost done as it seams; only the itest is missing

            People

            • Assignee:
              Felix Mayerhuber
              Reporter:
              Andreas Pieber
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: