Details

      Description

      void setFIle(File file);

      I doubt the capital I is intentional. It'd be an easy fix, but this breaks API compatibility...

        Gliffy Diagrams

        Error rendering 'com.meetme.plugins.jira.gerrit-plugin:gerritreviewsmodule'. Please contact your JIRA administrators.

          Activity

          Hide
          Andreas Pieber added a comment -

          I think we should add the corrected named version of the method in 2.x; remove the old one in 3.x and mark the 2.x version deprecated in 2.x

          Show
          Andreas Pieber added a comment - I think we should add the corrected named version of the method in 2.x; remove the old one in 3.x and mark the 2.x version deprecated in 2.x
          Hide
          Felix Mayerhuber added a comment -

          I'm afraid that won't be so easy. It's a typo with very bad consequences It causes this whole model to simply not work

          see
          https://groups.google.com/group/openengsb-dev/browse_thread/thread/35529f70ab5aabd4/7af8a60727ed7437#7af8a60727ed7437

          Show
          Felix Mayerhuber added a comment - I'm afraid that won't be so easy. It's a typo with very bad consequences It causes this whole model to simply not work see https://groups.google.com/group/openengsb-dev/browse_thread/thread/35529f70ab5aabd4/7af8a60727ed7437#7af8a60727ed7437
          Hide
          Felix Mayerhuber added a comment -

          ok ... it is for sure that this typo breaks the functionalaty of the model. The missspelled function has to be removed.

          Show
          Felix Mayerhuber added a comment - ok ... it is for sure that this typo breaks the functionalaty of the model. The missspelled function has to be removed.
          Hide
          Andreas Pieber added a comment -

          if it's such critical shouldnt we backport the fix to 2.4.1 too? Is the only thing required to remove the misspelledd function?

          Show
          Andreas Pieber added a comment - if it's such critical shouldnt we backport the fix to 2.4.1 too? Is the only thing required to remove the misspelledd function?
          Hide
          Andreas Pieber added a comment -

          I've assigned this to you felix; feel free to decide how to proceed; if it's really a bug I've no problem even removing it in a micro

          Show
          Andreas Pieber added a comment - I've assigned this to you felix; feel free to decide how to proceed; if it's really a bug I've no problem even removing it in a micro

            People

            • Assignee:
              Felix Mayerhuber
              Reporter:
              Stefan Dösinger
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: