OpenEngSB
  1. OpenEngSB
  2. OPENENGSB-3197

Move AbstractDataRow to EDB and rename it to something meaningful

    Details

    • Changelog:
      The AbstractDataRow is no longer publicly available. It has been moved to edb.jpa.internal
    • Sprint:
      Sprint 7, Sprint 8

      Gliffy Diagrams

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        Christoph Gritschenberger added a comment -

        I actually intended to remove all other references to that class.

        Show
        Christoph Gritschenberger added a comment - I actually intended to remove all other references to that class.
        Hide
        Lukas Stampf added a comment -

        Andis idea behind the AbstractDataRow was to have a base class for every JPA Entity, so each entity has some common fields, like created, version and a global unique id which can be useful sometimes. So I think moving the class to a specific bundle like the EDB contradicts this idea, no use to have an abstract base class just for one bundle.

        Show
        Lukas Stampf added a comment - Andis idea behind the AbstractDataRow was to have a base class for every JPA Entity, so each entity has some common fields, like created, version and a global unique id which can be useful sometimes. So I think moving the class to a specific bundle like the EDB contradicts this idea, no use to have an abstract base class just for one bundle.
        Hide
        Andreas Pieber added a comment -

        well, why not deleting it completely then as an alternative?

        Show
        Andreas Pieber added a comment - well, why not deleting it completely then as an alternative?
        Hide
        Christoph Gritschenberger added a comment -

        And move its functionality to EDB-entity(ies) directly. Fine with me.

        Show
        Christoph Gritschenberger added a comment - And move its functionality to EDB-entity(ies) directly. Fine with me.
        Hide
        Felix Mayerhuber added a comment -

        if we don't need the functionality in all entities, then merging it with EDB entities is probably the best approach

        Show
        Felix Mayerhuber added a comment - if we don't need the functionality in all entities, then merging it with EDB entities is probably the best approach

          People

          • Assignee:
            Christoph Gritschenberger
            Reporter:
            Christoph Gritschenberger
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile