OpenEngSB
  1. OpenEngSB
  2. OPENENGSB-3283

Improve the function toOpenEngSBModelEntries so that it checks if the getter it refers really exists

    Details

    • Changelog:
      Hide
      Now there exists a check in the model weaving, which checks if getters, which would be called in the injected code, are existing before the call is added to the injected code. If there is no getter existing, a warning will be printed and the corresponding field is ignored.
      Show
      Now there exists a check in the model weaving, which checks if getters, which would be called in the injected code, are existing before the call is added to the injected code. If there is no getter existing, a warning will be printed and the corresponding field is ignored.
    • Sprint:
      Sprint 7, Sprint 8

      Description

      Until now, the algorithm just assumes that the corresponding getter is available (the getters need to be used, since direct field access doesn't work when there are super classes involved). A simple check if the getter is there before the corresponding command is added to the method body should be enough. Also there should be a logger warn message if the setter isn't there.

        Gliffy Diagrams

        Error rendering 'com.meetme.plugins.jira.gerrit-plugin:gerritreviewsmodule'. Please contact your JIRA administrators.

          Activity

          Felix Mayerhuber created issue -
          Felix Mayerhuber made changes -
          Field Original Value New Value
          Description Until now, the algorithm just assumes that the corresponding getter is available (the getters need to be used, since direct field access doesn't work when there are super classes involved). A simple check if the getter is there before the corresponding command is added to the method body should be enough. Also there should be a logger warn message if the setter isn't there.
          Felix Mayerhuber made changes -
          Sprint Sprint 7 [ 7 ]
          Felix Mayerhuber made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Changelog Now there exists a check in the model weaving, which checks if getters, which would be called in the injected code, are existing before the call is added to the injected code. If there is no getter existing, a warning will be printed and the corresponding field is ignored.
          Resolution Fixed [ 1 ]
          Andreas Pieber made changes -
          Rank Ranked higher
          Andreas Pieber made changes -
          Sprint Sprint 7 [ 7 ] Sprint 7, Sprint 8 [ 7, 8 ]
          Felix Mayerhuber made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Andreas Pieber made changes -
          Workflow jira [ 15231 ] OpenEngSB Workflow [ 18996 ]
          Andreas Pieber made changes -
          Labels archived
          Stefan Scheiber made changes -
          Workflow OpenEngSB Workflow [ 18996 ] OpenEngSB 2 Workflow [ 23828 ]
          Stefan Scheiber made changes -
          Fix Version/s openengsb-3.0.0 [ 10169 ]
          Fix Version/s framework-3.0.0 [ 10488 ]
          Stefan Scheiber made changes -
          Fix Version/s openengsb-3.0.0.M1 [ 11164 ]
          Fix Version/s openengsb-3.0.0 [ 10169 ]

            People

            • Assignee:
              Felix Mayerhuber
              Reporter:
              Felix Mayerhuber
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile