[OPENENGSB-3197] Move AbstractDataRow to EDB and rename it to something meaningful Created: 30/Jul/12  Updated: 28/May/14  Resolved: 05/Sep/12

Status: Closed
Project: OpenEngSB
Component/s: framework
Affects Version/s: None
Fix Version/s: openengsb-3.0.0.M1

Type: Improvement Priority: Major
Reporter: Christoph Gritschenberger Assignee: Christoph Gritschenberger
Resolution: Fixed Votes: 0
Labels: archived

Changelog: The AbstractDataRow is no longer publicly available. It has been moved to edb.jpa.internal
Sprint: Sprint 7, Sprint 8

Comment by Felix Mayerhuber [ 30/Jul/12 ]

Maybe I'm the wrong here, but wasn't the sense of the AbstractDataRow that it doesn't only affect the EDB but the JPA persistence? At least I think Lukas told so.

Comment by Christoph Gritschenberger [ 30/Jul/12 ]

Well every Entity is derived from it. But it doesn't make sense anywhere except in the EDB.

Comment by Felix Mayerhuber [ 30/Jul/12 ]

Hmm ... isn't it rather common then? Because the AbstractDataRow is intended to JPA AFAIK and the EDB isn't required to be implemented with JPA

Comment by Christoph Gritschenberger [ 31/Jul/12 ]

That's exactly why it belongs in the edb-bundle. The edb-api (org.openengsb.framework.edb.api) does not specify such a class.
the impl-bundle (org.openengsb.framework.edb.jpa) implements the API using JPA and thus should contain said class.

Comment by Felix Mayerhuber [ 31/Jul/12 ]

But if someone things about replacing the edb.jpa with say edb.file this class wouldn't be present any more for all other parts of the OpenEngSB where it is needed?

Comment by Christoph Gritschenberger [ 31/Jul/12 ]

I actually intended to remove all other references to that class.

Comment by Lukas Stampf [ 31/Jul/12 ]

Andis idea behind the AbstractDataRow was to have a base class for every JPA Entity, so each entity has some common fields, like created, version and a global unique id which can be useful sometimes. So I think moving the class to a specific bundle like the EDB contradicts this idea, no use to have an abstract base class just for one bundle.

Comment by Andreas Pieber [ 31/Jul/12 ]

well, why not deleting it completely then as an alternative?

Comment by Christoph Gritschenberger [ 31/Jul/12 ]

And move its functionality to EDB-entity(ies) directly. Fine with me.

Comment by Felix Mayerhuber [ 31/Jul/12 ]

if we don't need the functionality in all entities, then merging it with EDB entities is probably the best approach

Generated at Thu Aug 16 04:38:24 CEST 2018 using JIRA 6.3.13#6344-sha1:62d2b41c1ddfd5b5a56568898407231b0d9c17cb.